Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for caching rotations #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

7ynk3r
Copy link

@7ynk3r 7ynk3r commented Jun 26, 2015

I've add support for rotations but it doesn't play well with estimatedRowHeight. I've found that this issue is independant of this implementation, meaning that this happens with cells that have different size depending on rotation and have estimatedRowHeight set. The problem is that the table doesn't update the cell's size after rotation so when you scroll you'll see the cells changing its size (bottom up). Still this works great if you avoiding the use of estimatedRowHeight, because it ask for the size of all the cells.
As an alternative we may calculate both heights (portrait & landscape) at the same time. Then use tableView:estimatedHeightForRowAtIndexPath: with that information or the table's estimatedRowHeight. The problem there is how to get the cell's width before the rotation occurs.
Let me know what do you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant